Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(refactor) Updated calcTimeDiff to use dayjs #63

Merged
merged 1 commit into from
Apr 28, 2023
Merged

(refactor) Updated calcTimeDiff to use dayjs #63

merged 1 commit into from
Apr 28, 2023

Conversation

CynthiaKamau
Copy link
Contributor

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

  • Updated calcTimeDiff to use dayjs

Screenshots

mmm

Related Issue

Other

pirupius
pirupius approved these changes Apr 28, 2023
View reviewed changes
Copy link
Member

@pirupius pirupius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CynthiaKamau CynthiaKamau merged commit f2bf709 into openmrs:main Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pirupius pirupius pirupius approved these changes

@samuelmale samuelmale Awaiting requested review from samuelmale

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CynthiaKamau @pirupius